Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprites in other languages #161

Open
DeveloperTruthStare opened this issue Feb 13, 2025 · 3 comments
Open

Sprites in other languages #161

DeveloperTruthStare opened this issue Feb 13, 2025 · 3 comments

Comments

@DeveloperTruthStare
Copy link

Specifically I'm thinking of the type sprites as those contain text.

I'd be willing to do this and make a PR, but would appreciate guidance on file structure so as to not break any dependencies.

@Naramsim
Copy link
Member

Hi can you first post a set of sprites? To let me understand more the problem

@DeveloperTruthStare
Copy link
Author

Here is the set of type sprites in Japanese. I just found these on google, not sure which game they come from if they even come from a game or are fan made.
Image

This is a screen shot of two of the sprites from the summary screen in FireRed Jpn version
Image

@phalt
Copy link
Member

phalt commented Feb 14, 2025

We have these currently and they are all in english.

Personally, I think we should extend the current directory with a jp/ (for Japanese, for example) directory and add them there.

Eventually we should move all current type badges into a en/ directory. I would not suggest doing this all in one go - step by step, as we might break people's apps :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants