Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests don't actually cover Celery 3.0.x #52

Open
midnightlynx opened this issue Jan 13, 2016 · 0 comments
Open

Tests don't actually cover Celery 3.0.x #52

midnightlynx opened this issue Jan 13, 2016 · 0 comments

Comments

@midnightlynx
Copy link
Contributor

If you examine the travis test outputs, testing currently doesn't actually test using Celery 3.0.

django-celery>=3.0,<3.0.21 didn't have an upper cap on their celery dependency, so on a fresh dependency install it installs celery 3.1.

django-celery>=3.0.21,<3.1 has an upper cap of celery<3.1, so it uses celery 3.0.

When using celery 3.0, the broker fallback tests and progress tests start failing.
It turns out when you use with self.settings(CELERY_ALWAYS_EAGER=True): in those tests, that properly changes the app setting for the way celery 3.1 builds the app, but doesn't change the setting for celery 3.0. So the tasks all turn up PENDING instead of SUCCESS.

Either testing should be fixed to cover that celery version, or the decision should be made to stop supporting celery<3.1. Doing the latter might be preferable, since celery supports django out of the box now, without needing django-celery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant