You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.
encodeURI and encodeURIComponent maybe the wrong function to encode/decode the hash, but i am just advocating for using the same function... not necessarily the correct one.
The text was updated successfully, but these errors were encountered:
why are the fragments decoded anyway? I can't seem to use a identifier with slashes for example with a url like http://localhost#/%2Fmy%2Fpath with the use-hash-as-path option as the fragment is decoded to //my/path
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
this.hash should use the same encoding and decoding functions. encodeURI and encodeURIComponent have subtle differences.
https://github.com/PolymerElements/iron-location/blob/master/iron-location.js#L88
window.decodeURIComponent(window.location.hash.slice(1));
https://github.com/PolymerElements/iron-location/blob/master/iron-location.js#L210
partiallyEncodedHash = '#' + window.encodeURI(this.hash);
encodeURI and encodeURIComponent maybe the wrong function to encode/decode the hash, but i am just advocating for using the same function... not necessarily the correct one.
The text was updated successfully, but these errors were encountered: