Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import of typography.html overrides any --paper-font-common-base mixin set. #584

Open
KeithHenry opened this issue Oct 30, 2017 · 1 comment

Comments

@KeithHenry
Copy link

paper-input imports ../paper-styles/typography.html in three places:

<link rel="import" href="../paper-styles/typography.html">

<link rel="import" href="../paper-styles/typography.html">

<link rel="import" href="../paper-styles/typography.html">

Each of these will cause any --paper-font-common-base mixin that is already set to be overridden with the typography.

Instead paper-input should not re-import typography.html, but it should include a comment similar to paper-radio-button's approach:

/*
This element applies the mixin `--paper-font-common-base` but does not import `paper-styles/typography.html`.
In order to apply the `Roboto` font to this element, make sure you've imported `paper-styles/typography.html`.
*/

See also this issue on paper-styles and this SO question.

@renfeng
Copy link

renfeng commented Oct 30, 2017

Paper elements should have consistency over --paper-font-common-base. I'd vote for paper-radio-button's approach as @KeithHenry suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants