Add support for CE attribute rendering. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds minimal attribute API to the dom-shim * custom-element opcodes refactored: * `custom-element-open` creates `ElementRenderer` and CE instance and calls `ElementRenderer:setAttribute()` for all static attributes * `attribute-part`: runs in between the `custom-element-open` and `custom-element-attributes` opcodes, to ensure any property/attribute bindings are set on the element before serializing the attributes * `custom-element-attributes`: runs `ElementRenderer:connectedCallback()`, and then renders attributes via `ElementRenderer:renderAttributes()` (default implementation serializes the dom-shim's attributes collection) * `custom-element-children`: renders the CE children via `ElementRenderer:renderAttributes()` * `lit-element-renderer.ts` no-ops the client-side `LitElement.render`, and then implements new `connectedCallback` and `attributeChangedCallback` abstract methods to call protected `UpdatingElement` lifecycle. * Note that `LitElement:performUpdate()` is called with a new flag to elide the `(first)updated` callbacks, since these (a) can't do anything good to the SSR output since they occur after `render()`, and (b) may more likely touch DOM. * Adds `SSRRenderOptions` to `render()`, and if `deferChildHydration` is true, it outputs a `defer-hydration` attribute on each CE * Escapes all attribute & textContent values (resolves TODO in code)
kevinpschaaf
changed the title
This was referenced Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
custom-element-opencreatesElementRendererand CE instance and callsElementRenderer:setAttribute()for all static attributesattribute-part: runs in between thecustom-element-openandcustom-element-attributesopcodes, to ensure any property/attribute bindings are set on the element before serializing the attributescustom-element-attributes: runsElementRenderer:connectedCallback(), and then renders attributes viaElementRenderer:renderAttributes()(default implementation serializes the dom-shim's attributes collection)custom-element-children: renders the CE children viaElementRenderer:renderAttributes()lit-element-renderer.tsno-ops the client-sideLitElement.render, and then implements newconnectedCallbackandattributeChangedCallbackabstract methods to call protectedUpdatingElementlifecycle.LitElement:performUpdate()is called with a new flag to elide the(first)updatedcallbacks, since these (a) can't do anything good to the SSR output since they occur afterrender(), and (b) may more likely touch DOM.