Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve paddings and various sizes for small laptop screens (and more comments) #12

Open
furilo opened this issue Feb 23, 2017 · 1 comment
Assignees
Labels

Comments

@furilo
Copy link
Member

furilo commented Feb 23, 2017

captura de pantalla 2017-02-23 a las 8 34 36

  • Logo and main text has almost no padding, they both are too near of screen edge
  • I'd make smaller the menu font-size
  • Why a tick for submitting the form? It feels strange to me
  • h1.section-title feels a little bit gigantic
  • Product cards:
    • should we have a border in the images or full cards?
    • It feels weird to me that the right edge of products its not aligned with the Products header
  • News: headings titles (of elements) is too big?
  • Logos: I'd make them smaller so they have more padding
  • Team heading center-aligned - any special reason to change relative to the other headings?
  • Footer: should we add some border-top or similar?
  • Menu: It keeps feeling strange to me the mix of the logo and menu items. I'd try separating them more, and making menu items smaller.

[Feel free to open specific issues for each item if needed]

@martgnz
Copy link
Contributor

martgnz commented Feb 23, 2017

The style isn't finished yet, that's why there are some rough edges here and there. Some issues are already open (#11, #6).

  • In general, I need to review the font sizes, and probably switch to another scale.
  • Need to check out how to add an inline SVG to submit the Revue form. It was a bit unclear how to do it with the current implementation so I added the tick as a placeholder.
  • Product cards
    • Need to think about the border.
    • There is a responsive issue with our padded columns hack, so I disabled a part of it.
  • Team: I didn't like it left-aligned, it looked weird. Now is less consistent, maybe I can fix this aligning the faces to the left too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants