Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FilterHighlightAnnotateOWASP.bambda #26

Merged
merged 5 commits into from
Dec 7, 2023
Merged

Add FilterHighlightAnnotateOWASP.bambda #26

merged 5 commits into from
Dec 7, 2023

Conversation

flamebarke
Copy link
Contributor

@flamebarke flamebarke commented Dec 6, 2023 •
edited
Loading

Bambda Contributions

  • Bambda has a valid header, featuring an @author annotation and suitable description
  • Bambda compiles and executes as expected
  • Only .bambda files have been added or modified (README.md files are automatically updated / generated after PR merge)

@flamebarke
Copy link
Contributor Author

https://www.phrack.me/tools/2023/12/04/Burp-Bambdas.html

Hannah-PortSwigger
Hannah-PortSwigger requested changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@Hannah-PortSwigger Hannah-PortSwigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the submission!

We really like this concept, and it's great to see you've done a blog post on the subject as well.

We've reviewed your Bambda, and have some suggestions relating to the readability of your Bambda, and improvements that could be made to the Java code.

If you have any issues implementing this feedback, please let us know and we'd be happy to help out.

Thank you again for your contribution to this repository!

Proxy/HTTP/FilterHighlightAnnotateOWASP.bambda Outdated Show resolved Hide resolved
Proxy/HTTP/FilterHighlightAnnotateOWASP.bambda Outdated Show resolved Hide resolved
Proxy/HTTP/FilterHighlightAnnotateOWASP.bambda Outdated Show resolved Hide resolved
Proxy/HTTP/FilterHighlightAnnotateOWASP.bambda Outdated Show resolved Hide resolved
flamebarke
flamebarke commented Dec 7, 2023
View reviewed changes
Copy link
Contributor Author

@flamebarke flamebarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback!
I have cleaned it up a bit and implemented your suggested changes. The notes are now only annotated with the potential vuln class and the parameter name to avoid cluttering the output as well.

ps-porpoise
ps-porpoise approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@ps-porpoise ps-porpoise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for much for incorporating those suggestions! :)

Hannah-PortSwigger
Hannah-PortSwigger approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@Hannah-PortSwigger Hannah-PortSwigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for implementing the feedback! This looks great 😄

@Hannah-PortSwigger Hannah-PortSwigger merged commit 573f7ed into PortSwigger:main Dec 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ps-porpoise ps-porpoise ps-porpoise approved these changes

@Hannah-PortSwigger Hannah-PortSwigger Hannah-PortSwigger approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flamebarke @Hannah-PortSwigger @ps-porpoise