guardian logic that supports zk login #70

Edward-BXS · 2024-07-04T10:04:51Z

No description provided.

guardianApprove verify operate details

Release/1.17.0

stevenportkey

Now we only implemented logics for CAHolder creation. What about other scenarios where Guardian approval is needed?

contract/Portkey.Contracts.CA/CAContract_Actions.cs

stevenportkey · 2024-07-05T01:03:29Z

contract/Portkey.Contracts.CA/CAContract_Actions.cs

+    public override Empty AddJwtIssuer(/*GuardianType guardianType, */StringValue input)
+    {
+        Assert(input != null, "Invalid Issuer.");
+        Assert(!input.Equals(State.JwtIssuers[GuardianType.OfGoogle]), "Google jwt issuer exists");
+        State.JwtIssuers[GuardianType.OfGoogle] = input.Value;
+        return new Empty();
+    }
+
+    public override Empty AddVerifyingKey(VerifyingKey input)
+    {
+        Assert(input != null, "Invalid verifying key.");
+        Assert(!string.IsNullOrEmpty(input.CircuitId), "circuitId is required.");
+        Assert(!string.IsNullOrEmpty(input.VerifyingKey_), "verifying key is required.");
+        State.CircuitIdToVerifyingKey[input.CircuitId] = input;
+        return base.AddVerifyingKey(input);
+    }
+
+    public override BoolValue IsValidIssuer(/*GuardianType guardianType, */StringValue input)
+    {
+        Assert(input != null, "Invalid verifying key.");
+        Assert(State.JwtIssuers[GuardianType.OfGoogle] != null
+            || State.JwtIssuers[GuardianType.OfApple] != null
+            || State.JwtIssuers[GuardianType.OfFacebook] != null, "verifying key doesn't exist.");
+        return new BoolValue
+        {
+            Value = true//State.JwtIssuers[guardianType].Equals(input)
+        };
+    }
+
+    public override VerifyingKey GetVerifyingKey(StringValue input)
+    {
+        Assert(input != null, "Invalid circuitId.");
+        Assert(State.CircuitIdToVerifyingKey[input.Value] != null, "circuitId not exist");
+        return State.CircuitIdToVerifyingKey[input.Value];
+    }


These are different group of methods. Please move them into a separate file.

stevenportkey · 2024-07-05T01:04:09Z

contract/Portkey.Contracts.CA/CAContract_Actions.cs

+    public override Empty StartOracleRequest(StartOracleRequestInput input)
+    {
+        Assert(input != null, "Invalid input.");
+        Assert(input.SubscriptionId > 0, "Invalid input subscription id.");
+        Assert(input.RequestTypeIndex > 0, "Invalid request type index.");
+
+        State.OracleContract.SendRequest.Send(new SendRequestInput
+        {
+            SubscriptionId = input.SubscriptionId,
+            RequestTypeIndex = input.RequestTypeIndex,
+            SpecificData = input.SpecificData
+        });
+
+        return new Empty();
+    }
+
+    public override Empty HandleOracleFulfillment(HandleOracleFulfillmentInput input)
+    {
+        Assert(input != null, "Invalid input.");
+        // Assert(IsHashValid(input.RequestId), "Invalid input request id.");
+        Assert(input.RequestTypeIndex > 0, "Invalid request type index.");
+        Assert(!input.Response.IsNullOrEmpty() || !input.Err.IsNullOrEmpty(), "Invalid input response or err.");
+        GoogleResponse reponse = JsonConvert.DeserializeObject<GoogleResponse>(System.Text.Encoding.UTF8.GetString(input.Response.ToByteArray()));
+        Assert(reponse != null, "Invalid input.");
+        //todo aetherlink can't differentiate apple/google/facebook
+        foreach (var googleKeyDto in reponse.Keys)
+        {
+            State.KidToPublicKey[GuardianType.OfGoogle][googleKeyDto.Kid] = googleKeyDto.N;
+        }
+
+        return new Empty();
+    }


These are different group of methods. Please move them into a separate file.

stevenportkey · 2024-07-05T01:04:26Z

contract/Portkey.Contracts.CA/CAContract_Actions.cs

+    internal class GoogleResponse
+    {
+        public List<GoogleKeyDto> Keys { get; set; }
+    }
+
+    internal class GoogleKeyDto
+    {
+        public string N { get; set; }
+        public string Kid { get; set; }
+        public string E { get; set; }
+        public string Alg { get; set; }
+        public string Kty { get; set; }
+        public string Use { get; set; }
+    }


Move into separate file.

stevenportkey · 2024-07-05T01:08:08Z

contract/Portkey.Contracts.CA/CAContract_Actions.cs

+        public List<GoogleKeyDto> Keys { get; set; }
+    }
+
+    internal class GoogleKeyDto


This is not specific to Google. Other providers follow the same.

https://www.facebook.com/.well-known/oauth/openid/jwks/?paipv=0&eav=AfZoWUgLyOKRPWYYbs05wEzwNngEk-s1_3Kx5sO3REdP_fCScnpPbBveGmTOF5FdgYg&_rdr

https://appleid.apple.com/auth/keys

stevenportkey · 2024-07-05T01:24:47Z

protobuf/ca_contract.proto

@@ -237,13 +272,57 @@ message GuardianInfo {
  GuardianType type = 1;
  aelf.Hash identifier_hash = 2;
  VerificationInfo verification_info = 3;
+  ZkJwtAuthInfo zk_oidc_info = 4;


Suggested change

ZkJwtAuthInfo zk_oidc_info = 4;

ZkLoginInfo zk_login_info = 4;

stevenportkey · 2024-07-05T01:28:59Z

contract/Portkey.Contracts.CA/CAContract_Actions.cs

@@ -162,13 +198,70 @@ public override Empty ReportPreCrossChainSyncHolderInfo(ReportPreCrossChainSyncH

        return new Empty();
    }
+
+    private bool CreateCaHolderInfoWithCaHashAndCreateChainIdForZkLogin(ManagerInfo managerInfo, GuardianInfo guardianApproved,


NoncePayload needs to be checked again actual operation taken in current transaction, e.g. AddManager for CreateCAHolder.

stevenportkey · 2024-07-05T01:33:24Z

contract/Portkey.Contracts.CA/CAContract_Helpers.cs

+    private byte[] Decode(string input)
+    {
+        if (input.IsNullOrEmpty())
+            throw new ArgumentException(nameof(input));
+
+        var output = input;
+        output = output.Replace('-', '+'); // 62nd char of encoding
+        output = output.Replace('_', '/'); // 63rd char of encoding
+        switch (output.Length % 4) // Pad with trailing '='s
+        {
+            case 0:
+                break; // No pad chars in this case
+            case 2:
+                output += "==";
+                break; // Two pad chars
+            case 3:
+                output += "=";
+                break; // One pad char
+            default:
+                throw new FormatException("Illegal base64url string.");
+        }
+        var converted = Convert.FromBase64String(output); // Standard base64 decoder
+        return converted;
+    }


Rename this to DecodeBase64Url.

stevenportkey · 2024-07-05T01:35:43Z

contract/Portkey.Contracts.CA/CAContract_Managers.cs

+            if (CanVerifyWithZkLogin(guardianInfo))
+            {
+                continue;
+            }


What is this for?

stevenportkey · 2024-07-05T01:36:30Z

contract/Portkey.Contracts.CA/BytesExtension.cs

Now we only implemented logics for CAHolder creation. What about other scenarios where Guardian approval is needed?

…acontract need add zk definitions,verifiers logic should be tested by qa

…hash when verifying zk

Feature/add workflows

chaoxkang and others added 7 commits May 9, 2024 20:54

Merge pull request #62 from Portkey-Wallet/release/1.15.0

1a8e848

guardianApprove verify operate details

Create test-with-code-coverage.yml

9784e99

feat: change dotnet version

8fa021c

feat: fix workflows

4582bec

feat: change ubuntu version

8c9faa7

Merge pull request #66 from Portkey-Wallet/release/1.17.0

d33733b

Release/1.17.0

guardian logic that supports zk login

0325605

stevenportkey requested changes Jul 5, 2024

View reviewed changes

Edward-BXS added 18 commits July 8, 2024 21:38

guardian/generate verifier/pr problems

88fdc99

transfer verifier pb code from cacontract to cacontractimpl,because c…

4da291a

…acontract need add zk definitions,verifiers logic should be tested by qa

add admin permission logic

6c2957d

change some parameter names

0bbb3df

change parameter names

7ade3d3

some unit tests

1928c5a

change zk definition

1067d42

add zk auth rule

4c680d5

extract zkproof data

35e9aa6

update contract

2602953

opt the code style

78693da

remove useless log

93220a9

add ut

7110f1f

guardian adjustment

c918684

change the method of setting public key and chunks, support poseidon …

93ef7ea

…hash when verifying zk

nonce datetime

4e9dd1b

adjustment of test problems

c31f2f9

update the latest package, fix the code check problems

0a21aa4

Edward-BXS force-pushed the feature/zklogin branch from c0cc42e to 0a21aa4 Compare August 19, 2024 14:53

issue template

35802cb

Edward-BXS linked an issue Aug 19, 2024 that may be closed by this pull request

ZkLogin #73

Open

Merge branch 'master' into feature/zklogin

975a558

Edward-BXS added 11 commits August 20, 2024 11:41

Merge pull request #75 from Portkey-Wallet/feature/add-workflows

bb9c39a

Feature/add workflows

change dotnet 6.0 to 8.0

2057dc5

change pipeline's .net sdk version to 8.0

b1e1704

Merge branch 'master' into feature/zklogin

abe2e52

adjustment the unit test

6e7c870

ut adjustment

cf87591

remove global.json

f4f0c24

change .net 8.0 to 6.0

da49c5b

recover the sdk and dotnet version

082ce86

change dotnet 8.0.107

7dcb54c

return the sdk version

f4914a4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

guardian logic that supports zk login #70

guardian logic that supports zk login #70

Edward-BXS commented Jul 4, 2024

stevenportkey left a comment •

edited

Loading

stevenportkey Jul 5, 2024

stevenportkey Jul 5, 2024

stevenportkey Jul 5, 2024

stevenportkey Jul 5, 2024

stevenportkey Jul 5, 2024

stevenportkey Jul 5, 2024

stevenportkey Jul 5, 2024

stevenportkey Jul 5, 2024

stevenportkey Jul 5, 2024

	ZkJwtAuthInfo zk_oidc_info = 4;
	ZkLoginInfo zk_login_info = 4;

guardian logic that supports zk login #70

Are you sure you want to change the base?

guardian logic that supports zk login #70

Conversation

Edward-BXS commented Jul 4, 2024

stevenportkey left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stevenportkey left a comment •

edited

Loading