fix tests

functional_tests/feature-flags.test.ts

@@ -22,6 +22,10 @@ test('person properties set in identify() with new distinct_id are sent to decid
 
     resetRequests(token)
 
+    // wait for decide callback
+    // eslint-disable-next-line compat/compat
+    await new Promise((res) => setTimeout(res, 500))
+
     // Person properties set here should also be sent to the decide endpoint.
     posthog.identify('test-id', {
         email: '[email protected]',
@@ -63,6 +67,10 @@ test('person properties set in identify() with the same distinct_id are sent to
 
     resetRequests(token)
 
+    // wait for decide callback
+    // eslint-disable-next-line compat/compat
+    await new Promise((res) => setTimeout(res, 500))
+
     // First we identify with a new distinct_id but with no properties set
     posthog.identify('test-id')
 
@@ -98,3 +106,36 @@ test('person properties set in identify() with the same distinct_id are sent to
         ])
     })
 })
+
+test('identify() doesnt trigger new request automatically if first request takes too long', async () => {
+    // TODO: Make this experience nicer, and queue requests, rather than leave
+    // it upto the user to call reloadFeatureFlags() manually.
+
+    const token = v4()
+    const posthog = await createPosthogInstance(token, { advanced_disable_decide: false })
+
+    const anonymousId = posthog.get_distinct_id()
+
+    await waitFor(() => {
+        expect(getRequests(token)['/decide/']).toEqual([
+            // This is the initial call to the decide endpoint on PostHog init.
+            {
+                distinct_id: anonymousId,
+                groups: {},
+                token,
+            },
+        ])
+    })
+
+    resetRequests(token)
+
+    // don't wait for decide callback
+
+    posthog.identify('test-id', {
+        email: '[email protected]',
+    })
+
+    await waitFor(() => {
+        expect(getRequests(token)['/decide/']).toEqual([])
+    })
+})

src/__tests__/compression.js

@@ -92,6 +92,8 @@ describe('Payload Compression', () => {
                 },
                 featureFlags: {
                     receivedFeatureFlags: jest.fn(),
+                    resetRequestQueue: jest.fn(),
+                    setReloadingPaused: jest.fn(),
                 },
                 _hasBootstrappedFeatureFlags: jest.fn(),
                 get_property: (property_key) =>

src/__tests__/decide.js

@@ -27,6 +27,8 @@ describe('Decide', () => {
         },
         featureFlags: {
             receivedFeatureFlags: jest.fn(),
+            resetRequestQueue: jest.fn(),
+            setReloadingPaused: jest.fn(),
         },
         _hasBootstrappedFeatureFlags: jest.fn(),
         getGroups: () => ({ organization: '5' }),

src/decide.ts

@@ -39,6 +39,9 @@ export class Decide {
     }
 
     parseDecideResponse(response: DecideResponse): void {
+        this.instance.featureFlags.resetRequestQueue()
+        this.instance.featureFlags.setReloadingPaused(false)
+
         if (response?.status === 0) {
             console.error('Failed to fetch feature flags from PostHog.')
             return
@@ -61,9 +64,6 @@ export class Decide {
             this.instance.featureFlags.receivedFeatureFlags(response)
         }
 
-        this.instance.featureFlags.resetRequestQueue()
-        this.instance.featureFlags.setReloadingPaused(false)
-
         this.instance['compression'] = {}
         if (response['supportedCompression'] && !this.instance.get_config('disable_compression')) {
             const compression: Partial<Record<Compression, boolean>> = {}