Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Expose version #1357

Merged
merged 2 commits into from
Aug 14, 2024
Merged

fix: Expose version #1357

merged 2 commits into from
Aug 14, 2024

Conversation

benjackwhite
Copy link
Collaborator

@benjackwhite benjackwhite commented Aug 13, 2024

Changes

Change to the type causes issue in posthog. Also it wasn't accounted for even in the tests for this repo
Also exposes the version so we don't have to rely on internal methods

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

@benjackwhite benjackwhite added the bump patch Bump patch version when this PR gets merged label Aug 13, 2024
@benjackwhite benjackwhite requested a review from robbie-c August 13, 2024 14:22
Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Aug 13, 2024 2:32pm

Copy link

github-actions bot commented Aug 13, 2024

Size Change: +185 B (+0.02%)

Total Size: 1.17 MB

Filename Size Change
dist/array.full.js 333 kB +47 B (+0.01%)
dist/array.js 154 kB +46 B (+0.03%)
dist/main.js 155 kB +46 B (+0.03%)
dist/module.js 154 kB +46 B (+0.03%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 10.4 kB
dist/recorder-v2.js 110 kB
dist/recorder.js 110 kB
dist/surveys-preview.js 59.8 kB
dist/surveys.js 66 kB
dist/tracing-headers.js 8.26 kB
dist/web-vitals.js 5.79 kB

compressed-size-action

@benjackwhite benjackwhite changed the title fix: Bad types change fix: Expose version Aug 13, 2024
@benjackwhite benjackwhite merged commit ca5c004 into main Aug 14, 2024
14 checks passed
@benjackwhite benjackwhite deleted the fix/types-issue branch August 14, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants