-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert: "fix: pass original fetch args along" #1371
Conversation
This reverts commit e2da050.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: -6 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
The same error has been fixed in dd-trace a while ago by calling fetch with the original input |
@ricardobeat interestingly that's a fix in DD for a different issue. their thread mentions it is difficult to test for but I'll see if i can poke about and recreate for us since we might be open to the same error as well (although haven't had it reported) |
@pauldambra the core issue is the same, wrapping fetch incorrectly. I meant to point to a potentially better solution vs the one at 24979cb which has been reverted, preserving a |
Reverts #1351
we've seen multiple reports of fetch wrapping causing errors, it would be amazing if it wasn't this change causing it.
it's safe to revert if it's not this change and important to revert if it is...