fix: zone detection #1570
Merged
fix: zone detection #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pauldambra
commented
Nov 28, 2024
|
Size Change: -1.07 kB (-0.03%) Total Size: 3.18 MB
ℹ️ View Unchanged
|
pauldambra
commented
Nov 28, 2024
Comment on lines
11
to
15
| + try { | ||
| + if (!isFunction(x)) { | ||
| + return false; | ||
| + } | ||
| + const prototypeKeys = Object.getOwnPropertyNames(x.prototype || {}); | ||
| + return prototypeKeys.some((key) => key.indexOf('__zone')); | ||
| + return !!globalThis.Zone | ||
| + } catch { | ||
| + // we've seen some intermittent problems in Safari since introducing this check | ||
| + return false | ||
| + } |
There was a problem hiding this comment.
turns out it is way simpler to just check if the global zone is present
if it's not, then angular didn't taint this
just like with the previous solution, folk can configure this to not be called zone, but then they can run posthog outside of the zone 🤷
thmsobrmlr
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mutation observer setup is sometimes failing in Safari
I think that the underlying problem is we can't reliably get the mutation observer from an iframe
but we are at least always trying to get it from an iframe instead of only when angular has monkeyed around with it
let's reduce the number of people affected by checking correctly
i've tested locally that this doesn't freeze the test angular app that would freeze if this didn't work
and i've tested locally that i can record safari (as much as i can, it wasn't always failing)