-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Load site functions via RemoteConfig #1580
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @benjackwhite! 👋 |
Size Change: +11 kB (+0.35%) Total Size: 3.21 MB
ℹ️ View Unchanged
|
# Conflicts: # playground/nextjs/src/posthog.ts # src/__tests__/site-apps.ts # src/site-apps.ts # src/types.ts # src/utils/globals.ts
__preview_remote_config: true, | ||
...configForConsent(), | ||
}) | ||
// Help with debugging(window as any).posthog = posthog | ||
// Help with debugging | ||
;(window as any).posthog = posthog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decided this should always be on as its super useful when testing around
# Conflicts: # src/__tests__/site-apps.ts # src/site-apps.ts # src/utils/logger.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The only question I had was if legacy site apps still work, but reading the code more it seems like that's handled. So ✅
They should do. The actual path for loading them is basically identical to before. I'll test again for sure before merging thouh. |
Changes
Needs #1581
Needs PostHog/posthog#26671
Checklist