fix(capture): Always update stored person props from $set #820
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
@simfish85 brought to my attention that every
posthog.people.set()
call fires an event, and I realized this can't quite be optimized away just by using the$set
property inposthog.capture()
'd events. That's because in the latter case, stored person properties don't get updated, potentially messing up feature flags.This PR adds the handling around stored person props that
posthog-people
had toposthog-core
. Let me know if this makes sense, I've not been involved in posthog-js lately.Checklist