Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a little session buffering logic #890

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Conversation

pauldambra
Copy link
Member

Trying to intuit my way to understanding what is happening with the session buffering.

Logically we can (when there is a minimum duration set):

  • have a buffer with data and a session id assigned
  • and then the session id changes
  • we would then compare the buffer's data timestamp
  • with the new session start timestamp
  • which would give us a negative duration
  • this would never meet the minimum test
  • and we would never flush that buffer

Let's make sure that doesn't happen

@pauldambra pauldambra requested a review from a team November 14, 2023 12:16
Copy link

github-actions bot commented Nov 14, 2023

Size Change: +40 B (0%)

Total Size: 733 kB

Filename Size Change
dist/array.full.js 174 kB +10 B (0%)
dist/array.js 115 kB +10 B (0%)
dist/es.js 115 kB +10 B (0%)
dist/module.js 115 kB +10 B (0%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12 kB
dist/recorder-v2.js 104 kB
dist/recorder.js 58.3 kB
dist/surveys.js 39.8 kB

compressed-size-action

@pauldambra pauldambra added the bump patch Bump patch version when this PR gets merged label Nov 14, 2023
@pauldambra pauldambra merged commit 89e7099 into master Nov 14, 2023
13 checks passed
@pauldambra pauldambra deleted the fix/a-little-session-logic branch November 14, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants