feat: payload capture - move timing into copied plugin #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +697 B (0%) Total Size: 740 kB
ℹ️ View Unchanged
|
pauldambra
commented
Nov 18, 2023
pauldambra
commented
Nov 18, 2023
| @@ -16,12 +16,8 @@ export const _isUint8Array = function (x: unknown): x is Uint8Array { | |||
| // fails on only one very rare and deliberate custom object: | |||
There was a problem hiding this comment.
fun fact: the URL in this comment might have said something about JS in the past but it doesn't anymore 🤷
pauldambra
commented
Nov 20, 2023
pauldambra
commented
Nov 20, 2023
marandaneto
reviewed
Nov 20, 2023
| // readonly name: string; | ||
| // readonly startTime: DOMHighResTimeStamp; | ||
| // properties below here are ALPHA, don't rely on them, they may change without notice | ||
| export type CapturedNetworkRequest = Omit<PerformanceEntry, 'toJSON'> & { |
There was a problem hiding this comment.
Not important because it covered all important stuff, but in case you are looking for ideas of what to track: https://opentelemetry.io/docs/specs/semconv/http/http-spans/#common-attributes
Eg HTTP version, etc.
benjackwhite
approved these changes
Nov 21, 2023
src/types.ts
Outdated
Comment on lines
162
to
163
| /** Modify the network request before it is captured. Returning null stops it being captured */ | ||
| // TODO this has to work for both capture mechanisms? 😱 | ||
| // deprecated - use maskCapturedNetworkRequestFn instead |
There was a problem hiding this comment.
Instead remove the original jsdoc and make it
/** @deprecated - use maskCapturedNetworkRequestFn instead */
benjackwhite
approved these changes
Nov 21, 2023
pauldambra
added a commit
to PostHog/posthog
that referenced
this pull request
Nov 21, 2023
requires: PostHog/posthog-js#902 We don't want to support running posthog/network and rrweb/network plugin at the same time. These changes support that change improve timeline display allow raw json view for debugging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed https://posthog.slack.com/archives/C03PB072FMJ/p1700077249746539
first draft (while looking after poorly #4) of removing our own timings plugin in favour of (a copy of) the rrweb plugin
TODO