Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(surveys): Add opt in migration #17600

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Conversation

neilkakkar
Copy link
Collaborator

@neilkakkar neilkakkar commented Sep 25, 2023

Problem

Changes

Part 3 of X of migrating surveys off of the site app. See part 4 for how it all comes together: #17602

This PR adds the migration for the toggle switch to enable/disable survey loading. This is then used in the decide response to determine when to generate surveys (part 4) - (posthog-js code for decide response in part 1: PostHog/posthog-js#801)

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

Run locally, see it's fine

@neilkakkar neilkakkar marked this pull request as ready for review September 25, 2023 12:45
@neilkakkar neilkakkar merged commit b4e5ac6 into master Sep 25, 2023
69 checks passed
@neilkakkar neilkakkar deleted the surveys-native-migration branch September 25, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants