feat: Swap to use dedicated version checker #24345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbie-c
reviewed
Aug 13, 2024
| const posthogVersion = | ||
| posthog.version ?? | ||
| (posthog as any)?._calculate_event_properties?.('test', {})?.['$lib_version'] ?? | ||
| '0.0.0' | ||
| const majorMinorVersion = posthogVersion.split('.') |
There was a problem hiding this comment.
Minor point, but we could also replace this with the functions from semver (would be along the lines of compareVersion(a,b) >= 0
There was a problem hiding this comment.
Given it is just a fallback I am going to be lazy and say no if thats alright 😅 but happy for you to take over and do it
# Conflicts: # frontend/src/toolbar/elements/heatmapLogic.ts
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: +13 B (0%) Total Size: 1.07 MB ℹ️ View Unchanged
|
Twixes
approved these changes
Aug 14, 2024
robbie-c
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Needs PostHog/posthog-js#1357
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?