Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement schema option for PsDscAdapter #563

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Gijsreyn
Copy link
Contributor

PR Summary

This pull request adresses partially the option to call dsc resource schema -r <resourceName> for PowerShell adapters. If I'm not wrong, there is also an overarching issue but I couldn't find it. Pardon me on it.

There are other questions popping up with this pull request:

  • How to define properties with types and description (proposal at 508)?
  • Should definition metadata be included?
  • How does the engine handle adapter resources to call schema executable through resource manifest?

PR Context

Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some tests

powershell-adapter/psDscAdapter/powershell.resource.ps1 Outdated Show resolved Hide resolved
@Gijsreyn
Copy link
Contributor Author

Gijsreyn commented Oct 2, 2024

Please add some tests

@SteveL-MSFT I added one test now with a hardcoded resource manifest. I'm struggling to find out the logic how dsc.exe handles adapter resources types. For now to not break the tests, i have hardcoded the type.

Do you mind helping me out and point me in the right direction? I would have expected the engine to call the dsc schema command on adapter resources directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants