Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Gallery should move to GitHub Commenting #51

Open
SydneyhSmith opened this issue Mar 26, 2019 · 4 comments
Open

The Gallery should move to GitHub Commenting #51

SydneyhSmith opened this issue Mar 26, 2019 · 4 comments

Comments

@SydneyhSmith
Copy link
Contributor

Please note that this is not an official proposal/committed work but a chance for community feedback and discussion on where the Gallery should go with commenting

Motivation

Livefyre, the current commenting service on the Gallery, doesn't always produce a great experience and it is difficult for us to quickly resolve bugs when they occur because it is a 3rd party service.
The text format of the comments is not ideal for commenting and debugging code.
Many package comments don't have a good response time because it can be difficult
for package owners to manage multiple flows of feedback.
Since many package owners already host their projects on GitHub and respond to issues
there, there is an opportunity to integrate these flows.
We believe that by integrating the Gallery comment section with Git Hub issues we
can improve the overall experience for both publishers and consumers.

Specification

  • A comment on the package page would open an issue on the GitHub project site
  • The feedback commenting system would be similar to the model used by Microsoft Docs
  • The commenting system would need to be configurable for those who host their
    packages on other repositories
  • Users should be able to read comments without needing an account of any type
  • Users will need/create a GitHub account to comment on packages
  • Livefyre commenting would remain, at least intermediately, for those without project sites

Open Questions

  • Would using GitHub instead of Livefyre be automatic, or opt-in?
  • Would old Livefyre comments be retained on the page?
@felixfbecker
Copy link

I like the idea of easy issue reporting, but please make it 100% clear that it is creating an issue and not a "comment". A comment is not an issue. As a maintainer I am scared of getting spammed with hundreds of GitHub issues that are not real issues but just general reviews or feedback ("it does xyz", "works great for abc", "not so good if you want to do cde").

@edyoung
Copy link
Contributor

edyoung commented Mar 27, 2019

Selfishly, I care about maintainability of the site, so I want a solution that leads in the end to the permanent retirement of livefyre commenting for all modules, even those that do not have GitHub pages.

@doctordns
Copy link

As a user, I'd like to see more and better documentation (that is on the PS Gallery). I

@lazywinadmin
Copy link

lazywinadmin commented Mar 29, 2019

So if i understand correctly each comment will generate a new github issue on the project github repo referenced.

Will you be able to fetch existing issues + their comments using the Github Issues API and show them on the PS Gallery project page ? I can see situations where duplicate would be created if the PSGallery user does not see existing issues.
Edit: Not a deal breaker for me, just would like to know.

@SydneyhSmith SydneyhSmith changed the title The Gallery should move away from Livefyre commenting The Gallery should move to GitHub Commenting Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants