-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node 22 #10854
Comments
$ grep -E "(require|import).*punycode" --exclude "*.map" --exclude "*.min.js" --exclude "*.md" --exclude "*.d.ts" --exclude "*.html" -r node_modules
node_modules/gaxios/node_modules/whatwg-url/lib/url-state-machine.js:const punycode = require("punycode");
node_modules/psl/dist/psl.js:var Punycode = require('punycode');
node_modules/psl/index.js:var Punycode = require('punycode');
node_modules/whatwg-url/node_modules/tr46/index.js:const punycode = require("punycode/");
node_modules/oauth-signature/node_modules/uri-js/dist/esnext/schemes/mailto.js:import punycode from "punycode";
node_modules/oauth-signature/node_modules/uri-js/dist/esnext/uri.js:import punycode from "punycode";
node_modules/oauth-signature/node_modules/uri-js/src/schemes/mailto.ts:import punycode from "punycode";
node_modules/oauth-signature/node_modules/uri-js/src/uri.ts:import punycode from "punycode";
node_modules/core-js/modules/web.url.constructor.js:var toASCII = require('../internals/string-punycode-to-ascii');
node_modules/tr46/index.js:var punycode = require("punycode");
node_modules/uri-js/dist/esnext/schemes/mailto.js:import punycode from "punycode";
node_modules/uri-js/dist/esnext/uri.js:import punycode from "punycode";
node_modules/tough-cookie/lib/cookie.js:const punycode = require("punycode/");
node_modules/htmlhint/node_modules/whatwg-url/lib/url-state-machine.js:const punycode = require("punycode");
node_modules/openai/node_modules/whatwg-url/lib/url-state-machine.js:const punycode = require("punycode");
Binary file node_modules/@esbuild/darwin-arm64/bin/esbuild matches Based on some manual investigation, there are at least two main blockers here:
|
I see that Node 23 is now the "current" release: https://nodejs.org/en/about/previous-releases Is it possible to jump straight to 23? |
I'd need to hear a strong argument for why we should run a non-LTS version in prod. |
Nevermind! I misread something elsewhere and thought that node had changed to doing LTS for every major release, not just the even-numbered ones, but this is not the case. |
For funsies, I upgraded node in my container and ran
master
against it. It seemed to load OK, with a warning aboutpunycode
:As Node 22 transitions into ACTIVE and more dependencies update to use it, this might be easily available to us. But there's no rush. Node 20 stays in MAINTENANCE mode until mid-2026.
The text was updated successfully, but these errors were encountered: