Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Nicer favicon & background image #3

Open
PatrickAlphaC opened this issue Nov 20, 2020 · 36 comments
Open

Nicer favicon & background image #3

PatrickAlphaC opened this issue Nov 20, 2020 · 36 comments
Assignees
Labels
enhancement New feature or request

Comments

@PatrickAlphaC
Copy link
Collaborator

PatrickAlphaC commented Nov 20, 2020

0.2 ETH to whomever:

  1. Adds a nicer background
  2. Adds a nicer favicon and actually makes it stick to the top
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.2 ETH (101.24 USD @ $506.2/ETH) attached to it.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 265 years, 12 months from now.
Please review their action plans below:

1) federicosan has been approved to start work.

Do you need a new logo? What about a shield with a lightning for the favicon? Do you have an online version of the site?

Learn more on the Gitcoin Issue Details page.

@federicosan
Copy link

Hi Patrick could you please answer my questions? thank you.

@PatrickAlphaC
Copy link
Collaborator Author

Hi @federicosan I messaged you on gitcoin, but I'll add it here too.

  1. Yes, a new logo, and that logo sounds great!
  2. The online version is https://preventflashloanattacks.com/

It's hosted on github pages and uses jekyll

@federicosan
Copy link

Thanks! The background is for the hero banner on top?

@PatrickAlphaC
Copy link
Collaborator Author

You got it!

@gitcoinbot
Copy link

@federicosan Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@federicosan
Copy link

Yes, still making the background and maybe some 3D.

@federicosan
Copy link

federicosan commented Nov 25, 2020

isometric-03

This is the background I've been working on, I still need to work on the logo, it seems the shield lightning concept is too used, and they're a huge amount of companies using it so I am back to the force field that is less common I will have something to show to you soon.

@PatrickAlphaC
Copy link
Collaborator Author

This is awesome!!! So @adamazad already worked on a logo that I think is very good for now. I think it will make sense to split the bounty up between the two of you.

@federicosan
Copy link

@PatrickAlphaC Ok, then I will finish this, export to SVG and png, and upload the illustrator source file. I will also send the other sketches I was doing, and submit a PR for the bounty payment, what do you think?

@federicosan
Copy link

@PatrickAlphaC could you please tell me the size of the banner? so I can submit the PR with the correct sizes, If you have a deployed version of the site I can also adapt the background for mobile.

@federicosan
Copy link

Ok I will export the art on png and svg and here is the css for the background gradient for it to be responsive.

background: rgb(81,135,170);
background: radial-gradient(circle, rgba(81,135,170,1) 0%, rgba(0,82,127,1) 50%, rgba(27,60,108,1) 100%); Could you please tell me where can we test this? I've seen you've change from jekyll to gatsby

@PatrickAlphaC
Copy link
Collaborator Author

I'm just changed back, but it looks like we will be going back to gatsby. Please give it another day for me to update it :)

@gitcoinbot
Copy link

gitcoinbot commented Dec 3, 2020

@federicosan Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@federicosan
Copy link

I am already finished, Will make a PR today. Please let me know if you have some issue with the deliverables.

@adamazad
Copy link
Member

adamazad commented Dec 4, 2020

@federicosan, please do a clean fork to avoid merge issues on the PR. I did a complete rebase of the repo. Improvements to the design are welcome. https://preventflashloanattacks.com/

@federicosan
Copy link

federicosan commented Dec 7, 2020

@adamazad Ok, I will see what I can do in addition to the background, I have forked the repo and cloned it and will be checking the code for additional improvements.

@gitcoinbot
Copy link

@federicosan Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@PatrickAlphaC
Copy link
Collaborator Author

@federicosan any update here? The background looks great, and I'm looking to do some more bounties. But wondering if I should close this one for now.

In any case. Let me know. Thanks

@federicosan
Copy link

Hi, I am working on adding the background to the page, if you like I would just make a pr with the image illustrator file so you can payme for the background, and keep working outside of the bounty to get this working with gatsby, I don't know gatsby so I was following tutorials on how to add background images. What do you think?

@adamazad
Copy link
Member

@federicosan, if you post the original copy (or a copy optimized for web), I can add the background in the next push.

I imagine we need to consider the options in regard to colors. I randomly picked a spectrum of red and yellow. Do you think you can create a nicer color scheme?

@PatrickAlphaC
Copy link
Collaborator Author

@adamazad if you want to take the image from above, it looks like it's the original. Then we can close out this PR. I'm happy to split the bounty between you two.

@adamazad
Copy link
Member

adamazad commented Dec 16, 2020 via email

@federicosan
Copy link

herobanner jpg-01-01
Here is a version with transparent background you can use this css for the gradient background
background: rgb(81,135,170);
background: radial-gradient(circle, rgba(81,135,170,1) 0%, rgba(0,82,127,1) 50%, rgba(27,60,108,1) 100%);

@adamazad adamazad self-assigned this Dec 19, 2020
@adamazad adamazad added the enhancement New feature or request label Dec 19, 2020
@federicosan
Copy link

@PatrickAlphaC Anything else needed to pay out the bounty for the background?

@PatrickAlphaC
Copy link
Collaborator Author

I don't think so, could you submit for the bounty? It looks like I can't pay out yet.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.2 ETH (128.48 USD @ $642.4/ETH) has been submitted by:


@federicosan
Copy link

I have submitted work, I don't know why is gitcoinbot not listing my username :/

@PatrickAlphaC
Copy link
Collaborator Author

It's not letting me pay you out either XD I'm asking gitcoin for help as to what's going on.

@federicosan
Copy link

federicosan commented Dec 24, 2020

I have received an email confirming my submission today, maybe the bot will now detect this.

@federicosan
Copy link

Hi @PatrickAlphaC Any news about payout? I contacted gitcoin's support because the bot was not working, they told me you were planning on tipping me and cancel the bountie but I am not sure what they meant.

@gitcoinbot
Copy link

⚡️ A tip worth 0.20000 ETH (215.89 USD @ $1079.45/ETH) has been granted to @federicosan for this issue from @PatrickAlphaC. ⚡️

Nice work @federicosan! Your tip has automatically been deposited in the ETH address we have on file.

@PatrickAlphaC
Copy link
Collaborator Author

@PatrickAlphaC
Copy link
Collaborator Author

The UI wasn't working, so I just tipped you the ETH. Thank you! Hope Gitcoin can fix this soon.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.2 ETH (215.89 USD @ $1079.45/ETH) attached to this issue has been cancelled by the bounty submitter

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants