Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: magic values #48

Open
arseneeth opened this issue Mar 15, 2021 · 0 comments
Open

Bug: magic values #48

arseneeth opened this issue Mar 15, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@arseneeth
Copy link
Contributor

Currently staking-rewards.js and farm-factory.js implements magic values in tests, for example:

expect((await setup.balancer.pool.balanceOf(accounts[1])).toString()).to.equal(toWei('0'));

should be something like:

expect((await setup.balancer.pool.balanceOf(staker)).toString()).to.equal(ZERO_BALANCE);
@renckorzay renckorzay added the bug Something isn't working label May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arseneeth @renckorzay