Skip to content

Commit

Permalink
Update for 7.1 compatability (#115)
Browse files Browse the repository at this point in the history
Update for patch 7.1 / Dalamud API11, no functional changes
  • Loading branch information
kbrighton authored Nov 20, 2024
1 parent 0bdacde commit fac2f70
Show file tree
Hide file tree
Showing 10 changed files with 14 additions and 14 deletions.
2 changes: 1 addition & 1 deletion XIVComboVX/Combos/DOL.cs
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ protected override uint Invoke(uint actionID, uint lastComboMove, float comboTim
}

if (IsEnabled(CustomComboPreset.GatherJobCorrectionFeature)) {
switch (LocalPlayer.ClassJob.Id) {
switch (LocalPlayer.ClassJob.RowId) {
case DOL.BtnID:
return actionID switch {
MIN.Prospect => IsEnabled(CustomComboPreset.GatherJobCorrectionIgnoreDetectionsFeature) ? actionID : BTN.Triangulate,
Expand Down
2 changes: 1 addition & 1 deletion XIVComboVX/Config/ConfigWindow.cs
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ public override void Draw() {
ImGui.MenuItem("Not logged in", false);
}
else {
ImGui.MenuItem($"{player.Name}: {player.ClassJob.GameData!.Abbreviation.ToString().ToUpper()} ({player.ClassJob.Id})", false);
ImGui.MenuItem($"{player.Name}: {player.ClassJob.Value.Abbreviation.ExtractText()} ({player.ClassJob.RowId})", false);
}

bool clickDebug = ImGui.MenuItem("Snapshot debug messages");
Expand Down
2 changes: 1 addition & 1 deletion XIVComboVX/CustomCombo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ protected static bool IsJob(params uint[] jobs) {
IPlayerCharacter? p = LocalPlayer;
if (p is null)
return false;
uint current = p.ClassJob.Id;
uint current = p.ClassJob.RowId;
foreach (uint job in jobs) {
if (current == job)
return true;
Expand Down
6 changes: 3 additions & 3 deletions XIVComboVX/GameData/ComboDataCache.cs
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ public unsafe (ushort Current, ushort Max) GetMaxCharges(uint actionID) {
if (player == null)
return (0, 0);

uint job = player.ClassJob.Id;
uint job = player.ClassJob.RowId;
byte level = player.Level;
if (job == 0 || level == 0)
return (0, 0);
Expand All @@ -130,8 +130,8 @@ private byte getCooldownGroup(uint actionID) {
if (this.cooldownGroupCache.TryGetValue(actionID, out byte cooldownGroup))
return cooldownGroup;

Lumina.Excel.ExcelSheet<Lumina.Excel.GeneratedSheets.Action> sheet = Service.GameData.GetExcelSheet<Lumina.Excel.GeneratedSheets.Action>()!;
Lumina.Excel.GeneratedSheets.Action row = sheet.GetRow(actionID)!;
Lumina.Excel.ExcelSheet<Lumina.Excel.Sheets.Action> sheet = Service.GameData.GetExcelSheet<Lumina.Excel.Sheets.Action>()!;
Lumina.Excel.Sheets.Action row = sheet.GetRow(actionID)!;

return this.cooldownGroupCache[actionID] = row.CooldownGroup;
}
Expand Down
2 changes: 1 addition & 1 deletion XIVComboVX/GameData/GameState.cs
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ internal bool IsChatVisible {

internal GameState() => Service.Client.Logout += this.clearCacheOnLogout;

private void clearCacheOnLogout() => this.chatLogPointer = null;
private void clearCacheOnLogout(int type, int code) => this.chatLogPointer = null;

public void Dispose() {
if (this.disposed)
Expand Down
2 changes: 1 addition & 1 deletion XIVComboVX/GameData/IconReplacer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ private unsafe uint getIconDetour(IntPtr actionManager, uint actionID) {
uint lastComboActionId = *(uint*)Service.Address.LastComboMove;
float comboTime = *(float*)Service.Address.ComboTimer;
byte level = player.Level;
uint classJobID = player.ClassJob.Id;
uint classJobID = player.ClassJob.RowId;

foreach (CustomCombo combo in this.customCombos) {
if (combo.TryInvoke(actionID, lastComboActionId, comboTime, level, classJobID, out uint newActionID))
Expand Down
2 changes: 1 addition & 1 deletion XIVComboVX/GameData/PluginAddressResolver.cs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ internal unsafe void Setup() {
this.ComboTimer = new IntPtr(&ActionManager.Instance()->Combo.Timer);

Service.Log.Information("Scanning for IsActionIdReplaceable signature");
this.IsActionIdReplaceable = Service.SigScanner.ScanText("E8 ?? ?? ?? ?? 84 C0 0F 84 ?? ?? ?? ?? C6 83 ?? ?? ?? ?? ?? 48 8B 5C 24");
this.IsActionIdReplaceable = Service.SigScanner.ScanText("40 53 48 83 EC 20 8B D9 48 8B 0D ?? ?? ?? ?? E8 ?? ?? ?? ?? 48 85 C0 74 1B");
}
catch (Exception ex) {
this.LoadFailReason = ex;
Expand Down
2 changes: 1 addition & 1 deletion XIVComboVX/XIVComboVX.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<PropertyGroup>
<Product>XIVComboVX</Product>
<Authors>VariableVixen, FrigidWalrus, attick, daemitus</Authors>
<Version>9.30.0</Version>
<Version>9.31.0</Version>
<Description>This plugin condenses various abilities onto single buttons.</Description>
<PackageProjectUrl>https://github.com/PrincessRTFM/XIVComboPlugin</PackageProjectUrl>
<Copyright>Copyleft attick 2020 baybeeee</Copyright>
Expand Down
2 changes: 1 addition & 1 deletion XIVComboVX/dalamud.props
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<Import Project="framework.props" />

<ItemGroup>
<PackageReference Include="DalamudPackager" Version="2.1.13" />
<PackageReference Include="DalamudPackager" Version="11.0.0" />
<Reference Include="Newtonsoft.Json">
<HintPath>$(DalamudLibPath)Newtonsoft.Json.dll</HintPath>
<Private>False</Private>
Expand Down
6 changes: 3 additions & 3 deletions XIVComboVX/packages.lock.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
"net8.0-windows7.0": {
"DalamudPackager": {
"type": "Direct",
"requested": "[2.1.13, )",
"resolved": "2.1.13",
"contentHash": "rMN1omGe8536f4xLMvx9NwfvpAc9YFFfeXJ1t4P4PE6Gu8WCIoFliR1sh07hM+bfODmesk/dvMbji7vNI+B/pQ=="
"requested": "[11.0.0, )",
"resolved": "11.0.0",
"contentHash": "bjT7XUlhIJSmsE/O76b7weUX+evvGQctbQB8aKXt94o+oPWxHpCepxAGMs7Thow3AzCyqWs7cOpp9/2wcgRRQA=="
}
}
}
Expand Down

0 comments on commit fac2f70

Please sign in to comment.