Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MATLAB metric subroutine needs fix #166

Closed
zhisong opened this issue Apr 27, 2022 · 2 comments
Closed

MATLAB metric subroutine needs fix #166

zhisong opened this issue Apr 27, 2022 · 2 comments
Assignees
@jloizu @abaillod

Comments

@zhisong
Copy link
Collaborator

zhisong commented Apr 27, 2022

The MATLAB subroutine get_spec_metric is not giving correct answers for the innermost volume. Most likely it is because there is a problem with get_spec_regularization_factor. In the new version of SPEC (>3.0) the regularization factors for coordinate interpolation have been changed. But this is not reflected in the MATLAB subroutines.
@abaillod
Copy link
Collaborator

Hi Zhisong,

True, the matlab tools on the master branch are very outdated (~2 years old). I pushed my updated routines to the branch matlab_update - you can try with these one.

I never found the time to properly test all these routines, so I never merged the branch with the master one...

@smiet
Copy link
Collaborator

smiet commented Oct 27, 2023

Fixed with PR #169 . Closing

@smiet smiet closed this as completed Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jloizu jloizu

@abaillod abaillod

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@smiet @zhisong @jloizu @abaillod