-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pc 1.21.1 data #925
Merged
Add pc 1.21.1 data #925
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6c0e144
Add pc 1.21 protocol data
extremeheat dbd79a6
fix
extremeheat 865eebe
Update dataPaths.json
extremeheat 57f1c0d
Merge branch 'master' into pc1.21
rom1504 be90b6b
to 1.21.1
extremeheat cebd74f
Fix packet_explosion
extremeheat 8142faf
Fix ChatTypes
extremeheat 4debf6c
Fix SlotComponentType missing repair_cost
extremeheat 8d2793f
1.21: Add some data (#927)
GroobleDierne c45e279
Merge branch 'master' into pc1.21
rom1504 5b9f5ea
add default in packet explosion switch for sound id
rom1504 843269e
use empty container instead of void in packet explosion so it works w…
rom1504 44ab383
also on 1.20.5
rom1504 7e27d23
recipes should have null not -1
rom1504 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is super weird; are you sure?
it means sounds id must be 0 or the packet is invalid since there is no default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
going to add default: void
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No default defaults to void anyway no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, no default means there is no default: other values are impossible and should crash