-
-
Notifications
You must be signed in to change notification settings - Fork 940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make toss more efficient #129
Comments
I agree it could be better, but I don't think it's worth the code complexity. The inventory code is already complicated enough; in order to solve this we might introduce more bugs or make it harder to stay up to date with the protocol. |
Ok, I guess I'll try and do this in my bot. |
I guess I can leave the issue open since it's still an issue. |
Originally closed for reference to rom1504/rbot#15 Reopened. Added to 1.7 Milestone. |
Fixing this issue consist of fixing the bot.transfer (https://github.com/andrewrk/mineflayer/blob/master/lib/plugins/inventory.js#L115) function. An idea would be not waiting after each click. |
see http://pastebin.com/tCjCbf4z (by Corgano) |
244fc7b fixes that issue. |
currently it's tossing item one by one, what would be more efficient is to cut the amount requested into stacks then using tossStack.
For an amount n you need n=q*64+r you need q 64-items stacks and one stack of r items.
It would take a lot less time than currently (it can take something like 10 seconds to toss 32 items)
The text was updated successfully, but these errors were encountered: