1.21

[Madlykeanu]

No description provided.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher

🚮 Removed packages: npm/[email protected]

View full report↗︎

[Madlykeanu]

chat works but its recieving it differently for some reason in 1.21

[Madlykeanu]

in 1.21 the type in the message is 1 for some reason, but in 1.20.6 it is 0, idk why this is happening, isnt type 1 mean its an action/emote message? whereas type 0 is player?

1.20.6

1.21

[rom1504]

Mojang usually breaks things for no reason.

Add a feature in mcdata to distinguish

[SuperGamerTron]

Looks like the chat types got incremented in the newest protocol version for whatever reason.

I was able to fix it with this: SuperGamerTron/prismarine-registry@6d2e1ca

[rom1504]

Please open a PR

…

On Fri, Oct 25, 2024, 20:10 SuperGamerTron ***@***.***> wrote: Looks like the chat types got incremented in the newest protocol version for whatever reason. image.png (view on web) <https://github.com/user-attachments/assets/c6140990-922f-4617-8633-3db4376ab3fd> I was able to fix it with this: ***@***.*** <SuperGamerTron/prismarine-registry@6d2e1ca> — Reply to this email directly, view it on GitHub <#3480 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR437VJRJXRNTZRJSU4U73Z5KCSHAVCNFSM6AAAAABQAJPQ3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZYGUYTMMJVGI> . You are receiving this because you commented.Message ID: ***@***.***>

[rom1504]

PrismarineJS/prismarine-registry#42

[rom1504]

Chat test fixed

[rom1504]

Failing at consume now with this

TypeError: SizeOf error for undefined : Cannot read properties of undefined (reading 'x')
at Object.vec2f (eval at compile (/home/runner/work/mineflayer/mineflayer/node_modules/protodef/src/compiler.js:262:12), :83:21)
at Object.packet_use_item (eval at compile (/home/runner/work/mineflayer/mineflayer/node_modules/protodef/src/compiler.js:262:12), :2308:26)
at eval (eval at compile (/home/runner/work/mineflayer/mineflayer/node_modules/protodef/src/compiler.js:262:12), :2376:56)
at packet (eval at compile (/home/runner/work/mineflayer/mineflayer/node_modules/protodef/src/compiler.js:262:12), :2379:9)
at CompiledProtodef.sizeOf (/home/runner/work/mineflayer/mineflayer/node_modules/protodef/src/compiler.js:89:14)
at e.message (/home/runner/work/mineflayer/mineflayer/node_modules/protodef/src/compiler.js:96:40)
at tryCatch (/home/runner/work/mineflayer/mineflayer/node_modules/protodef/src/utils.js:50:16)
at CompiledProtodef.createPacketBuffer (/home/runner/work/mineflayer/mineflayer/node_modules/protodef/src/compiler.js:96:20)
at Serializer.createPacketBuffer

Seems like wrong packet definition

[rom1504]

so the problem is pchat toString is producing "* flatbot hello" instead of " hello" which makes the test get stuck

[rom1504]

fixed that; we're now at fishing test

[rom1504]

I merged and released most deps

I left some comments in nmp and mcdata prs; would be nice to look into it so we can merge those too

[rom1504]

all external tests working

now only internal tests to fix

[rom1504]

now all passing but there seems to be a weird regression only in 1.19.2 https://github.com/PrismarineJS/mineflayer/actions/runs/11534777950/job/32109169450

[rom1504]

I do not reproduce any failure in 1.19.2 locally

[rom1504]

rerunning fixes it; something flaky

[rom1504]

tested jumper digger inventory manually, it works

[rom1504]

/makerelease