Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

PHEx 3.0.0 #1316

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

PHEx 3.0.0 #1316

wants to merge 15 commits into from

Conversation

PatheticMustan
Copy link
Member

Features

  • Moving PHEx to manifest version 3 (migration guide)
    • This includes a massive rework of how we handle scripts
  • updating /version, add support for multiple supported versions
  • remove duplicate code
  • make index page look nice

@PatheticMustan PatheticMustan added the DO NOT MERGE self explanatory. if you merge, i will smite you from the heavens label Feb 2, 2022
@Prodigy-Hacking Prodigy-Hacking locked and limited conversation to collaborators Feb 2, 2022
@PatheticMustan PatheticMustan marked this pull request as draft February 2, 2022 21:00
@PatheticMustan PatheticMustan linked an issue Feb 2, 2022 that may be closed by this pull request
[CRITICAL] Migrating PHEx to Manifest V3 #1231
Open
@LeoBadeaux
Copy link
Contributor

Does this work yet? What exactly has been completed, and if not, what's causing problems?

@PatheticMustan
Copy link
Member Author

I was hoping the label "DRAFT" and "DO NOT MERGE" would signal that it's currently a draft, and is not ready to merge.

@00100000
Copy link
Member

00100000 commented Feb 3, 2022

I was hoping the label "DRAFT" and "DO NOT MERGE" would signal that it's currently a draft, and is not ready to merge.

lmao chill nat

@LeoBadeaux
Copy link
Contributor

I was hoping the label "DRAFT" and "DO NOT MERGE" would signal that it's currently a draft, and is not ready to merge.

I just want to know what issues/bugs are being experienced

@PatheticMustan
Copy link
Member Author

PatheticMustan commented Feb 3, 2022 •
edited
Loading

there are no "issues/bugs", it's a draft of the new release...?
I listed the features I'm planning to implement already, but if you want I can explain what I'm planning to do, and why.

@PatheticMustan
Copy link
Member Author

why

@00100000
Copy link
Member

00100000 commented Feb 8, 2022

Hey hey, at best, I gave you the mental comfort of not being behind master, and at worst, I made an unnecessary extra commit.

@hostedposted
Copy link
Member

My commit makes it look like
image
or
image

@hostedposted hostedposted self-assigned this Feb 13, 2022
@00100000
Copy link
Member

Unnecessary eye candy :/

@PatheticMustan
Copy link
Member Author

very necessary eye candy, delicious even

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@PatheticMustan PatheticMustan

@ArcerionDev ArcerionDev

@hostedposted hostedposted

Labels
DO NOT MERGE self explanatory. if you merge, i will smite you from the heavens
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CRITICAL] Migrating PHEx to Manifest V3
7 participants
@PatheticMustan @LeoBadeaux @00100000 @hostedposted @afkvido @donaldli2020 @ArcerionDev