Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getResourceLoaderModules() is ignored if Component is member of NavbarHorizontal #409

Open
D-Groenewegen opened this issue Dec 20, 2023 · 0 comments

Comments

@D-Groenewegen
Copy link
Contributor

D-Groenewegen commented Dec 20, 2023

Hi, I've been trying out various custom components and noticed a bug with components that are nested within the horizontal navbar (type="NavbarHorizontal") in the XML layout. The HTML does get rendered without issues, but any modules added through getResourceLoaderModules() are ignored. The result remains the same for the following:

  • Custom components that are in the Skins\Chameleon\Components\NavbarHorizontal namespace
  • Custom components that are in the Skins\Chameleon\Components namespace - probably not the way to go, but same result.
  • The existing SearchBar component

There seems to be a selection process in Structure.php that decides which subcomponents should be queried for module names. Is it possible that there should be something equivalent in NavbarHorizontal.php (which can then go on to use getResourceLoaderModules() )?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant