Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in End-to-End Workflow step variable? #4

Open
xemio opened this issue Mar 28, 2023 · 3 comments
Open

Error in End-to-End Workflow step variable? #4

xemio opened this issue Mar 28, 2023 · 3 comments

Comments

@xemio
Copy link

xemio commented Mar 28, 2023

Hello,

In the Monai End-to-End Workflow notebook, we can notice that the step variable is initialized at 1. Shouldn't it be initialized at 0?

Kind regards

@xemio xemio changed the title Error in End-to-End Workflow Step variable? Error in End-to-End Workflow step variable? Mar 28, 2023
@ericspod
Copy link
Member

Hi @xemio I found that the issue is a little more complex than that but yes the value should start at 0. I have modified the notebooks now to calculate a proper loss average rather than an average of averages.

@xemio
Copy link
Author

xemio commented Mar 29, 2023

Thank you for your answer @ericspod. I wait for the commit of the changes.

@ericspod
Copy link
Member

Those changes are here now: #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants