Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace styfle/cancel-workflow-action #325

Closed
dopplershift opened this issue Oct 3, 2022 · 3 comments
Closed

Replace styfle/cancel-workflow-action #325

dopplershift opened this issue Oct 3, 2022 · 3 comments
Labels
infrastructure Infrastructure related issue needs triage This can be kept if the triager is unsure which next steps to take

Comments

@dopplershift
Copy link
Contributor

We should be able to do with with built in concurrency settings in GitHub Actions:

concurrency:
  group: ${{ github.workflow}}-${{ github.head_ref }}
  cancel-in-progress: true

Would eliminate some complexity and an external dependency.

@jukent jukent added infrastructure Infrastructure related issue needs triage This can be kept if the triager is unsure which next steps to take labels Oct 5, 2022
@brian-rose
Copy link
Member

I think it would be helpful (from a maintenance perspective) to harmonize the build-and-preview infrastructure for Foundations with what we're doing with Cookbooks.

Once things settle down on the Cookbook front, we should migrate the Cookbook infrastructure to this repo. That would be a good opportunity to eliminate the cancel-workflow-action dependency.

@brian-rose
Copy link
Member

Opened #335 to discuss migrating Cookbook infrastructure to this repo. I think we're ready to implement this.

@brian-rose
Copy link
Member

Closing since we're using the Cookbook infrastructure now for Foundations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Infrastructure related issue needs triage This can be kept if the triager is unsure which next steps to take
Projects
Status: Done
Development

No branches or pull requests

3 participants