From 3d11d84d7339ffe7f165cf2f15316a1d6660dd48 Mon Sep 17 00:00:00 2001
From: SGKoishi <i@sgkoi.dev>
Date: Sat, 13 May 2023 03:56:07 -0700
Subject: [PATCH 1/2] Fix dump-reference-data mutate command name

---
 TShockAPI/Permissions.cs | 15 +++------------
 docs/changelog.md        |  2 +-
 2 files changed, 4 insertions(+), 13 deletions(-)

diff --git a/TShockAPI/Permissions.cs b/TShockAPI/Permissions.cs
index d7ec7166d..debc8ea59 100644
--- a/TShockAPI/Permissions.cs
+++ b/TShockAPI/Permissions.cs
@@ -529,18 +529,9 @@ public static void DumpDescriptions()
 					field.GetCustomAttributes(false).FirstOrDefault(o => o is DescriptionAttribute) as DescriptionAttribute;
 				var desc = descattr != null && !string.IsNullOrWhiteSpace(descattr.Description) ? descattr.Description : GetString("No description available.");
 
-				var commands = GetCommands(name);
-				foreach (var c in commands)
-				{
-					for (var i = 0; i < c.Names.Count; i++)
-					{
-						c.Names[i] = "/" + c.Names[i];
-					}
-				}
-				var strs =
-					commands.Select(
-						c =>
-						c.Name + (c.Names.Count > 1 ? " ({0})".SFormat(string.Join(" ", c.Names.ToArray(), 1, c.Names.Count - 1)) : ""));
+				var strs = GetCommands(name).Select(c => c.Names.Count > 1
+					? $"{c.Name} ({string.Join(" ", c.Names.Skip(1).Select(n => $"/{n}"))})"
+					: c.Name);
 
 				sb.AppendLine($"## {name}");
 				sb.AppendLine($"{desc}");
diff --git a/docs/changelog.md b/docs/changelog.md
index 3f64f3554..d7b1d19f3 100644
--- a/docs/changelog.md
+++ b/docs/changelog.md
@@ -78,7 +78,7 @@ Use past tense when adding new entries; sign your name off when you add or chang
   * If there is no section called "Upcoming changes" below this line, please add one with `## Upcoming changes` as the first line, and then a bulleted item directly after with the first change. -->
 
 ## Upcoming changes
-Your changes could be here!
+* Fixed `/dump-reference-data` mutate the command names. (#2943, @sgkoishi)
 
 ## TShock 5.2
 * An additional option `pvpwithnoteam` is added at `PvPMode` to enable PVP with no team. (@CelestialAnarchy, #2617, @ATFGK)

From 51ecef73a16dd1df10bf093ef529be57c5bd1b64 Mon Sep 17 00:00:00 2001
From: Stargazing Koishi <i@sgkoi.dev>
Date: Sat, 13 May 2023 04:09:15 -0700
Subject: [PATCH 2/2] Optimize Linq

Co-authored-by: Arthri <41360489+Arthri@users.noreply.github.com>
---
 TShockAPI/Permissions.cs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/TShockAPI/Permissions.cs b/TShockAPI/Permissions.cs
index debc8ea59..99ac5d7d2 100644
--- a/TShockAPI/Permissions.cs
+++ b/TShockAPI/Permissions.cs
@@ -530,8 +530,8 @@ public static void DumpDescriptions()
 				var desc = descattr != null && !string.IsNullOrWhiteSpace(descattr.Description) ? descattr.Description : GetString("No description available.");
 
 				var strs = GetCommands(name).Select(c => c.Names.Count > 1
-					? $"{c.Name} ({string.Join(" ", c.Names.Skip(1).Select(n => $"/{n}"))})"
-					: c.Name);
+					? $"/{c.Name} (/{string.Join(" /", c.Names.Skip(1))})"
+					: $"/{c.Name}");
 
 				sb.AppendLine($"## {name}");
 				sb.AppendLine($"{desc}");