Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI #128

Closed
2 tasks done
AlexWaygood opened this issue Jan 21, 2022 · 2 comments
Closed
2 tasks done

Improve CI #128

AlexWaygood opened this issue Jan 21, 2022 · 2 comments

Comments

@AlexWaygood
Copy link
Collaborator

AlexWaygood commented Jan 21, 2022

Neither of these should be a massive priority, but there are two changes that might be good:

  • Run mypy with --strict. There are still a fair few dynamically typed functions in the code base; these need type annotations to be added for us to start doing this.
  • Add a pre-commit bot to auto-reformat a PR with black and isort. I think this dramatically improved the contributor experience over at typeshed. We obviously have far fewer contributors over at flake8-pyi, so it really doesn't need to be prioritised. However, this kind of auto-reformatting also makes it much easier to prepare (or start preparing) a PR on an iPad or mobile device, which is something I like to do :)
@JelleZijlstra
Copy link
Collaborator

I gave pre-commit.ci access to this repo. We'll need to add a pre-commit config file to get autoformatting like we do on typeshed.

@AlexWaygood
Copy link
Collaborator Author

We now run mypy with --strict in CI, and have made a number of other CI improvements, so I'm closing this.

Ideally we'd have a fully typed codebase, which would mean we wouldn't have to run mypy with --allow-subclassing-any,
--allow-untyped-defs and
--allow-incomplete-defs. But getting there depends on #183, so I don't think this issue needs to stay open anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants