From cefc8a4f30db6224d4211d231678a19db2aff1dd Mon Sep 17 00:00:00 2001 From: Michael Simacek Date: Tue, 21 Jan 2025 08:56:04 +0100 Subject: [PATCH 1/2] Add GraalPy 24.1 version to CI --- .github/workflows/build.yml | 4 ++++ .github/workflows/ci.yml | 1 + 2 files changed, 5 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index ed24957ad2a..5fb2124836e 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -38,6 +38,10 @@ jobs: - name: Install nox run: python -m pip install --upgrade pip && pip install nox + - if: inputs.python-version == 'graalpy24.1' + name: Install GraalPy virtualenv (only GraalPy 24.1) + run: python -m pip install 'git+https://github.com/oracle/graalpython#egg=graalpy_virtualenv_seeder&subdirectory=graalpy_virtualenv_seeder' + - name: Install Rust toolchain uses: dtolnay/rust-toolchain@master with: diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 14531d17144..1fde1b89054 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -245,6 +245,7 @@ jobs: "pypy3.9", "pypy3.10", "graalpy24.0", + "graalpy24.1", ] platform: [ From 17b78a76ae15a8737307d6a5b27e92ac700f89ac Mon Sep 17 00:00:00 2001 From: Michael Simacek Date: Thu, 23 Jan 2025 13:42:03 +0100 Subject: [PATCH 2/2] Skip failing test on GraalPy --- pytests/tests/test_comparisons.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pytests/tests/test_comparisons.py b/pytests/tests/test_comparisons.py index 50bba81cb1a..fe4d8f31f62 100644 --- a/pytests/tests/test_comparisons.py +++ b/pytests/tests/test_comparisons.py @@ -1,5 +1,6 @@ from typing import Type, Union +import sys import pytest from pyo3_pytests.comparisons import ( Eq, @@ -28,6 +29,11 @@ def __ne__(self, other: Self) -> bool: return NotImplemented +@pytest.mark.skipif( + sys.implementation.name == "graalpy" + and __graalpython__.get_graalvm_version().startswith("24.1"), # noqa: F821 + reason="Bug in GraalPy 24.1", +) @pytest.mark.parametrize( "ty", (Eq, EqDerived, PyEq), ids=("rust", "rust-derived", "python") )