Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nondeterminism bug in parmest #3372

Open
blnicho opened this issue Sep 19, 2024 · 1 comment
Open

Nondeterminism bug in parmest #3372

blnicho opened this issue Sep 19, 2024 · 1 comment

Comments

@blnicho
Copy link
Member

blnicho commented Sep 19, 2024

Summary

@djlaky discovered an issue in parmest with constraints being generated in a nondeterministic order. We think we've tracked the issue to this line in parmest where we are using a Python set to make sure the list of theta names does not have duplicates:

self.estimator_theta_names = list(set(theta_names))

The fix suggested by @jsiirola is to use the following to create a list without duplicates:

my_list = list(dict.fromkeys(list_with_duplicates))
@djlaky
Copy link
Contributor

djlaky commented Jan 14, 2025

@blnicho Wanted to follow up on this issue from our conversation at the PSE stakeholder meeting last week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants