You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As we discussed offline, we should update the cross-section interface to use the phase space point introduced in #51. This will change the signature of all interface functions.
The input validation can be dropped, because this is checked on the construction of the PSP.
Further changes
Following the suggestions in #46, one could drop the support of vectors of vectors of four-momenta in the form of a matrix but use Julia's broadcasting instead, e.g.
Consequently, we could fully drop the support for the five-argument versions (e.g. differential_cross_section(proc, model, ps_def, in_ps, out_ps)) of the probabilities and cross sections in favor of the PSP.
The text was updated successfully, but these errors were encountered:
With this, we update the process and cross-section interface to adopt
the new phase space points. This solved #57.
# TODOs
- [x] update tests for process interface
- [x] update test implementation for processes
- [x] update process interface description
- [x] update tests for cross-section and probability
- [x] update building of cross sections and probabilities
- [x] update perturbative compton
- [x] old interface (incl. versions for vectors of inputs)
- [x] cleanup
---------
Co-authored-by: Uwe Hernandez Acosta <[email protected]>
Co-authored-by: Anton Reinhard <[email protected]>
As we discussed offline, we should update the cross-section interface to use the phase space point introduced in #51. This will change the signature of all interface functions.
This can be seen as an extension of #46 .
Suggested interface
The new interface could look like this: (
PSP == PhaseSpacePoint
)If these functions are implemented, the following functions are built up using the interface:
The input validation can be dropped, because this is checked on the construction of the PSP.
Further changes
Following the suggestions in #46, one could drop the support of vectors of vectors of four-momenta in the form of a matrix but use Julia's broadcasting instead, e.g.
Consequently, we could fully drop the support for the five-argument versions (e.g.
differential_cross_section(proc, model, ps_def, in_ps, out_ps)
) of the probabilities and cross sections in favor of the PSP.The text was updated successfully, but these errors were encountered: