Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenericQEDProcess #96

Merged
merged 5 commits into from
Aug 27, 2024
Merged

Conversation

AntonReinhard
Copy link
Member

@AntonReinhard AntonReinhard commented Aug 21, 2024

Adds a generic QED process, implementing the basic AbstractProcessDefinition interface and allowing any combination of particles and spins/pols for them.
The constructor validates that the given spins and polarizations fit to the particles (fermion -> spin, boson -> polarization).

The actual computational functions are as of yet unimplemented and will later be added using the QEDfeynman_diagrams project, once that is public.

Therefore, for now the main use of this type is for testing purposes of other functions.

Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, thanks for providing this! I like the clean structure of the code. There are just some minor concerns and some naming things from my side.

src/processes/generic_process/process.jl Outdated Show resolved Hide resolved
src/processes/generic_process/process.jl Outdated Show resolved Hide resolved
src/processes/generic_process/process.jl Outdated Show resolved Hide resolved
src/processes/generic_process/process.jl Outdated Show resolved Hide resolved
src/processes/generic_process/utility.jl Outdated Show resolved Hide resolved
src/processes/generic_process/utility.jl Show resolved Hide resolved
src/processes/generic_process/utility.jl Show resolved Hide resolved
test/processes/generic_process/process.jl Outdated Show resolved Hide resolved
@szabo137 szabo137 self-requested a review August 27, 2024 16:42
@szabo137 szabo137 merged commit 0d157e3 into QEDjl-project:dev Aug 27, 2024
4 checks passed
@AntonReinhard AntonReinhard deleted the generic-process branch August 28, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants