Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integTestGen.jl does not use dev branches to determine dependencies #18

Closed
SimeonEhrig opened this issue Oct 12, 2023 · 2 comments
Closed
Assignees
Labels
01 - Bug Something isn't working as expected; needs a fix 08 - Testing Related to unit or integration tests

Comments

@SimeonEhrig
Copy link
Member

During the work on this QEDjl-project/QEDprocesses.jl#19 , I detect an error, because a variable was defined twice: https://gitlab.com/hzdr/qedjl-project/QEDprocesses-jl/-/jobs/5271231765

Normally, this should be captured by the integration tests. But for unknown reasons, QEDbase.jl do not check QEDprocesses. But QEDprocesses has a dependency to QEDbase.jl: https://github.com/QEDjl-project/QEDprocesses.jl/blob/0074aa02285d5ef39e63f5a204e02ac4b5b1f6d8/Project.toml#L8

@SimeonEhrig SimeonEhrig added 01 - Bug Something isn't working as expected; needs a fix 08 - Testing Related to unit or integration tests labels Oct 12, 2023
@SimeonEhrig SimeonEhrig self-assigned this Oct 12, 2023
@SimeonEhrig
Copy link
Member Author

I found the reason for the bug. The traversing algorithm might be correct. But it uses the states of the Project.toml in the registry. If we a new QED dependency to the Project.toml of a QED project, the new dependency is invisible for the integTestGen.jl until we do a new release in the registry. I will fix it by pull the current dev version, when the integTestGen.jl script is executed.

@SimeonEhrig SimeonEhrig changed the title bug in traversing algorithm of integTestGen.jl integTestGen.jl does not use dev branches to determine dependencies Oct 17, 2023
@SimeonEhrig
Copy link
Member Author

solved in #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
01 - Bug Something isn't working as expected; needs a fix 08 - Testing Related to unit or integration tests
Projects
None yet
Development

No branches or pull requests

1 participant