-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any plans to migrate to CMake? #53
Comments
We are not using CMake (yet!) so don't have much experience about it. If someone wants to make a patch for CMake we would gladly take it in if it works besides qmake. And yes, nanovg could be an external dependency / git submodule. But it needs to be our fork (https://github.com/QUItCoding/nanovg/) as there are additions which are not in upstream version like nvgBeginFrameAt() and support for adjusting paint antialiasing amount. Opted to include proper version inside but either way suits us. Regarding Qt6, OpenGL should work as-is but best way forward there would be RHI port (https://code.qt.io/cgit/qt/qtbase.git/tree/src/gui/rhi/) which would make QNanoPainter compatible with not just OpenGL but also Vulkan, Metal & Direct3D. Patches highly welcome for this too =) |
Since Qt6 is adopting CMake as its default build system, it would be nice if this library is migrated to CMake. Also I think it's best if nanovg is not included in the project and instead it should be listed as an external dependency.
The text was updated successfully, but these errors were encountered: