You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have not audited this recently, but these files should probably be reorganized.
A couple of examples:
There may a be a function that is called only from one file. In some cases it would be better to move this function from its current location to the file with the call sites, and make its visibility more restricted by removing pub or pub(crate).
No intentional order determines where the functions appear in the file. Some thought should be put into this and the functions (and data) should be reordered so that the code is easier to read and understand.
The text was updated successfully, but these errors were encountered:
openqasm3_parser/crates/oq3_parser/src/parser.rs
Lines 18 to 26 in dac0d7a
The "actual parsing" mentioned above is spread out among these files in this directory and subdirectory:
https://github.com/Qiskit/openqasm3_parser/tree/main/crates/oq3_parser/src/grammar
I have not audited this recently, but these files should probably be reorganized.
A couple of examples:
There may a be a function that is called only from one file. In some cases it would be better to move this function from its current location to the file with the call sites, and make its visibility more restricted by removing
pub
orpub(crate)
.No intentional order determines where the functions appear in the file. Some thought should be put into this and the functions (and data) should be reordered so that the code is easier to read and understand.
The text was updated successfully, but these errors were encountered: