Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement timing literals as literals with suffix #214

Open
jlapeyre opened this issue Apr 3, 2024 · 1 comment
Open

Implement timing literals as literals with suffix #214

jlapeyre opened this issue Apr 3, 2024 · 1 comment

Comments

@jlapeyre
Copy link
Collaborator

jlapeyre commented Apr 3, 2024

The spec currently sort of implies that there must not be whitespace between the number and suffix of a timing literal. That is

Good

100ns;
1.02s;

Bad

100 ns;
1.02 s;

However this parser currently allows spaces. The reference parser does as well.

It would simplify the parser (wide sense) if spaces were not allowed. Alternatively, we could make all of "100 ns" a token in the lexer. I'm pretty sure that there are no other tokens that are handled specially in this way at the moment.

Best would be to disallow spaces. But perhaps we should check for clarification with the TSC.

@jwoehr
Copy link

jwoehr commented May 15, 2024

Was this clarified?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants