Remove dependence on crate ra_ap_stdx #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove importing stdx::eprintln!. This was unused in any case * Vendor a very small macro `format_to` from ra_ap_stdx. This was the last feature that we used from that library. * Remove ra_ap_stdx from crates/oq3_syntax/Cargo.toml * Remove a macro call testing whether we are in the rust tree. CI failed locally with this test. We are never in the rust tree, so it should be removed in any case.
|
CI is failing:
I built and ran CI locally with both versions. Maybe I refreshed the lock file inadvertently... |
rowan 0.5.16 requires rust 1.77. We need to support rust 1.70 Apparently rowan 0.5.15 is enough
|
It looks like this PR is ok. The macos-11 CI is stuck. I've seen it in the past. Can't recall if it actually runs after a few hours. |
|
macos-11 is removed as an image - we'll need to update the runner to use macos-12 at least. |
I'll make a PR for that first, tomorrow (NY time) |
jlapeyre
force-pushed
the
upgrade-ra-ap-stdx
branch
from
3a89d0d
to
f79ea34
Compare
macos-11 causes CI to fail, or hang, because the image for macos-11 is no longer available. macos-12 is also not available.
jlapeyre
force-pushed
the
upgrade-ra-ap-stdx
branch
from
f79ea34
to
83416da
Compare
|
@mtreinish, bump. I think is ok? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
format_tofrom ra_ap_stdx. This was the last feature that we used from that library.Closes #229