Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move qiskit-aer and qiskit-ibm-runtime to test deps #690

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpopesculian
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Oct 3, 2024

CLA assistant check
All committers have signed the CLA.

@garrison
Copy link
Member

garrison commented Oct 8, 2024

Thank you for the PR.

The reason I haven't removed aer yet as a dependency is explained in my comment at #148 (comment). (I could elaborate on this, if it would be helpful, and I should double check that it is still accurate.) I see no issue with removing qiskit-ibm-runtime as a direct dependency. And the hesitation about removing aer as a dependency is really due to a quirk in the design of qiskit-ibm-runtime.

In order to remove both, I'd like to know that the notebook tests run with or without aer installed. I'd be willing to help configure tox.ini to enable this if we can first demonstrate it to be the case.

These packages will also need to be added to the notebook-dependencies, and this deserves a release note once we decide the path forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants