Fixed MPS save failure when memory limit is ignored #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we use this PR to fix the MPS memory usage estimation (here)? I am currently not familiar enough with MPS to see if there's an obvious bug leading to a wrong memory estimation. |
doichanj
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug preventing MPS runs when the estimated memory usage is too big, even if memory limit is disabled.
Fixes #2246
Details and comments
When
max_memory_mb=-1the maximum memory amount check for MPS should be disabled; however,Executor<state_t>::get_max_parallel_shotsstill uses the estimated memory in its computation, which might result in the value0, disabling the run of the engine altogether. To prevent this,get_max_parallel_shotsresults to themem==0case if the maximum memory amount check is disabled.