-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I cannot select a specific commitment #7
Comments
wondering what your thought is behind this. I had always considered the commitment to be the finite data people are eventually trying to drill down to, so I'm wondering why it would need to be selectable. |
Hey, I have an idea for making the commitment more accessible. I also implemented it, but I don't know how to create a new branch and a new PR. It must be something with the permission. |
@Tuanhao I am on it. |
@Tuanhao This should be fixed now, please let me know. |
So PR #10 will have a panel on a side of the commitments list. It is just a prototype, no styling yet. What do you guys think? |
I like the idea, although styling definitely needs to be done. The description information can definitely be done better though, having a fetch go out each time you click can not only have issues with performance (network, slicing through the content, etc), but with the engine available to us and the fact that those descriptions are more than likely to remain static, I think it would be much better to either ask the UN if they have this data available or do a one time scrape of this, then have the engine ingest that data into the app. |
further to that last comment, if we were to ingest the descriptions into the app we may find a use for integrating the search capabilities built of the engine into our app |
True. It would be better if we make a one time scraping thing. Or we can show this to the UN (if possible) and they may provide us the information, then we can add it to the engine. I dont know scrapping and much about engine too, so it will be a great experience for me to learn. |
Clicking on a commitment brings me to its page. We need a way to select that is separate from clicking to go to the page.
The solution needs to be the same for all lists.
The text was updated successfully, but these errors were encountered: