You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Negative numbers are tokenized as [Minus, Number] tokens, which is an issue because get_column_names_from_insert_into_query and get_column_values_from_insert_into_query
start returning different number elements.
These 2 must always match on number of elements, or panic, as otherwise:
I have a patch for this that needs some work, as it affects both tokenezation and parsing.
Simple query that failed for us:
INSERT INTO`test` (`count`) VALUES (-1);
The #167 pull request is trying to address this by gracefully handling mismatch, but unless I forget some niche sql features, they must always match when columns are explicitly provided.
The #110 (2) is most likely result of mismatching columns vs values.
The text was updated successfully, but these errors were encountered:
ikrestov
added a commit
to ikrestov/Replibyte
that referenced
this issue
Jul 28, 2022
Negative numbers are tokenized as [Minus, Number] tokens, which is an issue because
get_column_names_from_insert_into_query
andget_column_values_from_insert_into_query
start returning different number elements.
These 2 must always match on number of elements, or panic, as otherwise:
is wrong.
I have a patch for this that needs some work, as it affects both tokenezation and parsing.
Simple query that failed for us:
The #167 pull request is trying to address this by gracefully handling mismatch, but unless I forget some niche sql features, they must always match when columns are explicitly provided.
The #110 (2) is most likely result of mismatching columns vs values.
The text was updated successfully, but these errors were encountered: