-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fork actions/setup-python
as Quansight-Labs/setup-python
#107
Comments
Wow, you've done almost everything already, thanks @colesbury! I have created the two forks (https://github.com/Quansight-Labs/python-versions, https://github.com/Quansight-Labs/setup-python) under this org with the right config, and added @Quansight-Labs/free-threaded-team and @colesbury with maintain permissions. @andfoy volunteered to take point on the maintenance. @andfoy can you take the next steps here in both repos? |
@andfoy you may have to review the enabled and disabled actions in more detail. I disabled the ones that don't seem relevant (some were already disabled after forking), while the ones that may be needed for a release I left enabled. From https://github.com/Quansight-Labs/setup-python/actions/: |
I'll create pull requests in the forks to make the process a bit easier. |
I've just published |
I confirm it is working as expected: https://github.com/andfoy/scipy/actions/runs/11692095380/job/32560698824 |
It's working well for me, too. I tested on I did however notice an issue on Window with lots of log messages (dir listings of installed files). |
Converting NumPy's CI was straightforward: numpy/numpy#27707 |
Thanks for all the work in putting this together! This was extremely easy to drop in and get running. I'm running into an issue on the
the linking works fine on linux and macos, and the PR: SWxTREC/pymsis#61 |
@greglucas that looks like mesonbuild/meson#13851, which is MinGW-specific and isn't yet included in a Meson release (hopefully 1.6.1 will appear soon). In SciPy we're currently working around that like so (linking all the pieces that pull in Meson from GitHub for Windows cp313t wheel builds):
|
Fantastic, thanks @rgommers! That looks like it fixed the problem and the windows free threading wheels are building again. Thanks again everyone for the work in making this so seamless and supporting so many projects in this transition. |
While we wait for GitHub to review the PRs to support free-threaded Python (actions/setup-python#973, actions/python-versions#319), Quansight Labs can host a fork of
setup-python
that supports it. Here are the steps:python-versions
Fork actions/python-versions into the
Quansight-Labs
org. Make sure GitHub actions are enabled in the fork.Merge the five commits from the
colesbury/python-versions
quansight branch into the main branch of the new fork. In addition to the changes from my upstream PR, this branch has a few modifications to make it work outside of theactions
organization, and to merge versions from upstreamactions/python-versions
(so that we don't have to rebuild every single Python version).Run the "Build Python Package" step at https://github.com/Quansight-Labs/python-versions/actions/workflows/build-python-packages.yml with the following options. This will take ~30 minutes:
Branch: main
Python version: 3.13.0
Whether to publish releases: Yes (IMPORTANT!)
CPython threading build modes: freethreaded
Platforms: ubuntu-20.04,ubuntu-22.04,ubuntu-24.04,macos-13_x64,macos-14_arm64,windows-2019_x64,windows-2019_x86
(Only the "publish releases" needs to be changed -- the other options should be the same as the defaults)
This will take about 30 minutes and automatically publish a 3.13.0 release on the fork.
versions-manifest.json
file.setup-python
Quansight-Labs
org. Make sure GitHub actions are enabled in the fork.colesbury/setup-python
quansight branch into the main branch of the new fork. In addition to the changes from my upstream PR, this branch changes the organization (forversions-manifest.json
) toQuansight-Labs
.v5
tag as long.Usage
Projects should be able to swap
actions/setup-python
withQuansight-Labs/setup-python
and hopefully everything will "just work". Free threaded Pythons will be pulled fromQuansight-Labs/python-versions
while non-free threaded versions should continue working without any extra changes.cc @rgommers
The text was updated successfully, but these errors were encountered: