Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: standard econ filters/smoothers #131

Open
jstac opened this issue Jul 19, 2016 · 15 comments
Open

Feature request: standard econ filters/smoothers #131

jstac opened this issue Jul 19, 2016 · 15 comments

Comments

@jstac
Copy link
Contributor

jstac commented Jul 19, 2016

I don't think there are any packages in Julia that implement nice versions of the standard filters used in econ, like the HP filter. See, e.g., time series filters here:

http://statsmodels.sourceforge.net/stable/tsa.html#time-series-filters

This is another important filter, for seasonal adjustment:

https://www.census.gov/srd/www/x13as/x13down_unix.html

In Python and R there are wrappers:

https://github.com/christophsax/seasonal
http://statsmodels.sourceforge.net/devel/_modules/statsmodels/tsa/x13.html

but not Julia, as far as I know.

@robertdkirkby
Copy link

robertdkirkby commented Jul 20, 2016

Sébastian Villemot @sebastien-villemot wrote command to implement the hpfilter would likely be easy enough to just use his as base for the package. He likes free software so I imagine he would be happy enough for you to use it.
http://www.econforge.org/posts/2014/juil./28/cef2014-julia/

@svillemot
Copy link

Sure, feel free to reuse that code under a BSD or GPL license.

@jstac
Copy link
Contributor Author

jstac commented Jul 20, 2016

@sebastien-villemot Many thanks.

Anyone interested in this project please let me know.

@vgregory757
Copy link
Contributor

I will work on some of the time series filters from statsmodels.

@sglyon
Copy link
Member

sglyon commented Oct 13, 2016

Sounds great.

Make sure to check the license on stats models before looking at their code.

@cc7768
Copy link
Member

cc7768 commented Oct 13, 2016

Statsmodels seems to be licensed under Modified BSD (3-clause)

@mm3509
Copy link

mm3509 commented Jul 23, 2018

How about the seasonality filter with X-13ARIMA, did that suggestion go places, or does it exist in another package?

@andi3141
Copy link

I am interested in the project. As this issue is still marked open, is anyone working on it?

@jstac
Copy link
Contributor Author

jstac commented Sep 21, 2020

@Shunsuke-Hori , you did some work with filters didn't you?

@jstac
Copy link
Contributor Author

jstac commented Sep 21, 2020

@andi3141 , would you be willing to look at the existing filters in the library, linked to above, and then review those open PRs?

That might be a good way to get started.

@sglyon How does this sound to you? (Some of those PRs have already had input and could be ready to merge without further review.)

@andi3141
Copy link

@jstac sure, no problem. Happy to help

@sglyon
Copy link
Member

sglyon commented Sep 22, 2020

Thanks @jstac that sounds good to me.

@andi3141 please take a look at the pull requests and leave a comment when you've finished reviewing. Then we can work towards getting them merged.

@andi3141
Copy link

andi3141 commented Oct 7, 2020

So I had a look at the HP, Hamilton, and BK filter, which all seem fine. I am currently looking at the Kalman filter. In the pull request 235, an example file kalman_tracking_2d_example.jl is added to the example folder. What is the purpose of these example files? Are those files supposed to run without any packages added prior? There is only one other example file in the library so far, so it is hard for me to judge.

@Shunsuke-Hori
Copy link
Collaborator

@andi3141

Are those files supposed to run without any packages added prior?

I guess so, though I'm not the person who added them.
Example codes are typically used to illustrate practical usage of a package.
I don't think it's strictly necessary in this repository, but it won't hurt to have it (as long as it works).

If you could check the example file as well and leave a comment on #235, that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants