Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chang_credible] ValueError: The algorithm terminated successfully #131

Open
najuzilu opened this issue Jun 1, 2020 · 9 comments
Open

Comments

@najuzilu
Copy link
Contributor

najuzilu commented Jun 1, 2020

Lecture chang_credible fails with the following error:
Screen Shot 2020-06-01 at 2 33 44 PM

I suspect it could have something to do with the following warning:
Screen Shot 2020-06-01 at 2 31 33 PM

The version of scipy and polytope packages are:

scipy                     1.4.1
polytope                  0.2.2 
@mmcky
Copy link
Contributor

mmcky commented Jun 1, 2020

@najuzilu once you open these individual PRs for the specific lectures can you review and close #79 and #89 as duplicates

@najuzilu
Copy link
Contributor Author

najuzilu commented Jun 1, 2020

@mmcky will do.

@najuzilu
Copy link
Contributor Author

najuzilu commented Jun 2, 2020

Hi @thomassargent30 and @shizejin, you can find details regarding the chang_credible lecture above. I thought there was an issue with the missing polytope package but I have installed it and the issue persists (at a closer look, it makes sense that the issue is not related to the polytope package).

From my limited understanding, the error means that the problem cannot be solved within the given constraints.

@shizejin
Copy link
Member

shizejin commented Jun 5, 2020

Thanks @najuzilu, it is true that polytope is redundant. There are duplicated imports in this lecture which we need to address after we solve the current "infeasibility" issue.

The current problem happens during the search for optimal consumption when the constraint on the real balance is not binding. May I ask @mmcky if the code was working before? It would be extremely helpful to know at which update was this error first raised. According to my investigation so far the construction of subgradients and hyperplane levels looks good to me and I may look into scipy.optimize.linprog.

@mmcky
Copy link
Contributor

mmcky commented Jun 9, 2020

hi @shizejin - the code has worked before but it has been an issue for some time. We didnt' have CI setup at that stage so don't exactly know the software stack. It has had an issue since scipy=1.4.1 but not sure how much earlier than that.

@shizejin
Copy link
Member

shizejin commented Jun 9, 2020

Thanks @mmcky, this is very helpful. I will investigate into scipy.optimize.linprog and see if anything has changed on that side.

@mmcky
Copy link
Contributor

mmcky commented Feb 14, 2021

@shizejin do you have time to have another look into this issue? It would be great to get the advanced lectures back to 100% execution. I just don't have the skills needed to fix this one :-).

@shizejin
Copy link
Member

@mmcky thank you so much for pinging me! I should definitely finish investigating this. I will work on it in the following days.

@mmcky
Copy link
Contributor

mmcky commented Feb 22, 2021

thanks @shizejin let me know if I can help in any way. It would be awesome to get advanced back to 100% execution on the live site

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants